Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typing): AttrFunction #1669

Merged
merged 3 commits into from
Jan 12, 2021
Merged

fix(typing): AttrFunction #1669

merged 3 commits into from
Jan 12, 2021

Conversation

maxma241
Copy link
Contributor

code snippet
https://github.com/cheeriojs/cheerio/blob/main/lib/api/attributes.js#L113

value.call(el, i, el.attribs[name])

the first argument is thisArg not the function args

@fb55 fb55 merged commit 5f2e9c3 into cheeriojs:main Jan 12, 2021
@fb55
Copy link
Member

fb55 commented Jan 12, 2021

Nice find, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants