Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export namespace "cheerio" #1695

Closed
wants to merge 1 commit into from
Closed

Export namespace "cheerio" #1695

wants to merge 1 commit into from

Conversation

rondonjon
Copy link

Closes #1692

@rondonjon rondonjon force-pushed the feature/export-typescript-definitions branch from edb307e to 8651f6e Compare January 22, 2021 19:01
@rondonjon rondonjon changed the title Unwrap Typescript definitions Export namespace "cheerio" Jan 22, 2021
@5saviahv
Copy link
Contributor

You may also look #1682, both PRs are very similar reasons. Simply look other PR also.

@rondonjon
Copy link
Author

Withdrawing this PR because the suggested solution with export default seems to cause problems in environments that don't have esModuleInterop: true configured, see this explanation from DefinitelyTyped

@rondonjon rondonjon closed this Jan 23, 2021
@rondonjon rondonjon mentioned this pull request Jan 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typescript error "ts(4023)" caused by index.d.ts
2 participants
@rondonjon @5saviahv