Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add icq module & add fee-abs docker tests #787

Merged
merged 74 commits into from
Oct 1, 2024
Merged

Conversation

atheeshp
Copy link
Collaborator

@atheeshp atheeshp commented Sep 26, 2024

  • Adds ICQ module, which requires to use fee-abs, no need to integrate ICQ (it requires on the other network, in this case on osmosis) and no need to open the icqhost port on cheqd
  • Adds fee-abstraction tests

@atheeshp atheeshp changed the base branch from main to develop September 26, 2024 09:24
Copy link
Collaborator Author

@atheeshp atheeshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits

tests/fee-abs/cheqd/host_zone.json Show resolved Hide resolved
tests/fee-abs/cheqd/proposal.json Outdated Show resolved Hide resolved
tests/fee-abs/hermes/set_hermes_accounts.sh Outdated Show resolved Hide resolved
tests/fee-abs/osmosis/deploy_osmosis_contract.sh Outdated Show resolved Hide resolved
tests/fee-abs/osmosis/pool.json Show resolved Hide resolved
tests/fee-abs/osmosis/send_ibc_and_create_pool.sh Outdated Show resolved Hide resolved
Copy link
Collaborator Author

@atheeshp atheeshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits

.gitignore Outdated Show resolved Hide resolved
tests/fee-abs/cheqd/proposal.json Outdated Show resolved Hide resolved
tests/fee-abs/osmosis/pool.json Outdated Show resolved Hide resolved
@atheeshp atheeshp changed the title feat: Add icq module & add fee-abs docker tests feat: add icq module & add fee-abs docker tests Sep 26, 2024
@atheeshp atheeshp marked this pull request as ready for review September 26, 2024 12:03
Copy link
Contributor

@Eengineer1 Eengineer1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks well polished.

Approved.

@Eengineer1 Eengineer1 merged commit 26d77d1 into develop Oct 1, 2024
17 checks passed
@Eengineer1 Eengineer1 deleted the add-icq-module branch October 1, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants