feat: Support DID accreditations [DEV-4415] #601

DaevMithran · 2024-09-23T10:04:58Z

accredit/issue api
accredit/verify api
Add relevant tests

ankurdotb · 2024-09-23T10:05:51Z

Task linked: DEV-4415 Start on implementations

DaevMithran · 2024-10-01T08:11:53Z

src/controllers/api/accreditation.ts

+			eventTracker.emit('track', trackInfo);
+
+			return response.status(StatusCodes.OK).json({
+				didUrls: [


Would be helpful to receive suggestions on the response schema

Currently it is

didUrls: [ didUrlwithPathparam, didUrlwithQueryParam ]

accreditation: the vc jwt

For the query param version, is the name of the accreditation escaped correctly in case it has characters like spaces? Does it even allow spaces?

Yes @ankurdotb spaces are allowed, the query params are parsed by the express router

What happens if the credential issuance part is successful, but creating the resource fails?

We return a 500

DaevMithran · 2024-10-01T08:13:16Z

src/controllers/api/accreditation.ts

+	public async verify(request: Request, response: Response) {
+		// Extract did from params
+		let { verifyStatus = false, allowDeactivatedDid = false } = request.query as VerifyCredentialRequestQuery;
+		const { accreditation, policies, subjectDid } = request.body;


Here accreditation in request body is a didUrl.

Can I just receive it as did, resourceName, resourceType or resourceId separately?

Could you deconstruct a DID URL to those parts? We do something similar on Creds API, IIRC.

src/app.ts

src/controllers/api/accreditation.ts

ankurdotb · 2024-10-01T16:04:14Z

src/controllers/api/accreditation.ts

+			eventTracker.emit('track', trackInfo);
+
+			return response.status(StatusCodes.OK).json({
+				didUrls: [


For the query param version, is the name of the accreditation escaped correctly in case it has characters like spaces? Does it even allow spaces?

Yes @ankurdotb spaces are allowed, the query params are parsed by the express router

What happens if the credential issuance part is successful, but creating the resource fails?

We return a 500

ankurdotb · 2024-10-01T16:26:06Z

src/types/swagger-api-types.ts

+ *       connector:
+ *         type: string
+ *         enum:
+ *           - verida
+ *           - resource


Verida won't be an allowed connector for this, will it?

@ankurdotb we still haven't removed verida connector from our code entirely, we just disabled it. Should I remove it?

ankurdotb · 2024-10-01T16:26:22Z

src/types/swagger-api-types.ts

+ *         - issuerDid
+ *         - subjectDid
+ *         - schemas
+ *       example:


Bad example?

ankurdotb · 2024-10-01T16:27:09Z

tests/e2e/parallel/credential/issue-verify-flow.spec.ts

Why is this test being skipped?

I am going to debug this in a separate PR. JSONLD issuance using Jsonwebkey 2020 is failing

ankurdotb · 2024-10-01T16:28:18Z

tests/e2e/payloads/accreditation/accredit-jwt.json

+	"accreditationName": "accreditAccreditation",
+	"parentAccreditation": "did:cheqd:testnet:5RpEg66jhhbmASWPXJRWrA?resourceName=authorizeAccreditation&resourceType=VerifiableAuthorisationForTrustChain",
+	"rootAuthorization": "did:cheqd:testnet:5RpEg66jhhbmASWPXJRWrA?resourceName=authorizeAccreditation&resourceType=VerifiableAuthorisationForTrustChain"


Seems like same DID as parent and root. Can we do at least two different levels?

@ankurdotb it is done it the attestation test. At one point there should be a single level when the parent is root

tests/e2e/sequential/accreditation/issue-verify-flow.spec.ts

DaevMithran added 2 commits September 23, 2024 13:23

feat: Add resource connector in credential issuance

332471b

Add accredit/issue api

e9b4bb0

DaevMithran changed the title ~~feat: Support DID accreditations~~ feat: Support DID accreditations [DEV-4415] Sep 23, 2024

fix swagger

2522d16

DaevMithran force-pushed the accreditation branch from 6f1ceab to 2522d16 Compare September 23, 2024 10:20

DaevMithran marked this pull request as draft September 23, 2024 10:27

Implement accredit verify [skip ci]

4f58f29

DaevMithran force-pushed the accreditation branch from 9c61a7e to 4f58f29 Compare September 24, 2024 09:13

Add a separate controller for accreditation

0186b87

DaevMithran force-pushed the accreditation branch from 0c44623 to 0186b87 Compare September 25, 2024 06:56

DaevMithran marked this pull request as ready for review September 25, 2024 06:57

DaevMithran added 3 commits September 25, 2024 12:36

fix imports

5b7c00d

Update response

ebfeabe

Pause failing test

82f0385

DaevMithran force-pushed the accreditation branch from fe4146d to 82f0385 Compare September 25, 2024 07:43

Add accreditation tests

d2d2018

DaevMithran force-pushed the accreditation branch from a205d34 to d2d2018 Compare September 25, 2024 08:02

DaevMithran added 2 commits September 25, 2024 13:43

fix bugs

2fbd9df

Add auth rules

9d693c2

DaevMithran force-pushed the accreditation branch from fa5d838 to 9d693c2 Compare September 25, 2024 08:35

DaevMithran added 2 commits September 25, 2024 14:42

fix resource data format

76bb5b9

fix issue test

67ad60e

DaevMithran force-pushed the accreditation branch 5 times, most recently from c8adad8 to bb4d8c5 Compare September 25, 2024 10:24

Add accreditation/verify test

24529ef

DaevMithran force-pushed the accreditation branch from bb4d8c5 to 24529ef Compare September 25, 2024 10:31

DaevMithran force-pushed the accreditation branch from 158668d to cb2be30 Compare September 30, 2024 07:13

Execute sequential tests

81b80a7

DaevMithran force-pushed the accreditation branch from cb2be30 to 81b80a7 Compare September 30, 2024 07:17

fix verification

7f979c4

DaevMithran force-pushed the accreditation branch from 7fbef86 to 7f979c4 Compare September 30, 2024 08:09

Handle validations

81321d3

DaevMithran force-pushed the accreditation branch 2 times, most recently from 6d5caae to 14377ca Compare September 30, 2024 11:05

fix root validation logic

ec0d373

DaevMithran force-pushed the accreditation branch 4 times, most recently from 0958a9b to c96b540 Compare September 30, 2024 12:13

fix test payloads

de4c2a4

DaevMithran force-pushed the accreditation branch from c96b540 to de4c2a4 Compare September 30, 2024 12:52

DaevMithran requested a review from Eengineer1 September 30, 2024 13:37

Update swagger

6ae1669

DaevMithran force-pushed the accreditation branch from e15c2ef to 6ae1669 Compare October 1, 2024 06:20

Use validate decor

ee85311

DaevMithran commented Oct 1, 2024

View reviewed changes

ankurdotb added 4 commits October 1, 2024 17:16

npm update

1914752

Update package-lock.json

ce3153e

Fix verbatimModuleSyntax error in build

328b04e

Setting verbatimModuleSyntax to false

c04936a

ankurdotb requested changes Oct 1, 2024

View reviewed changes

Address PR comments

60ce93f

DaevMithran force-pushed the accreditation branch from 9982c7a to 7d274f5 Compare October 4, 2024 07:57

Update accreditation auth

8696023

DaevMithran force-pushed the accreditation branch from 7d274f5 to 8696023 Compare October 4, 2024 08:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Support DID accreditations [DEV-4415] #601

feat: Support DID accreditations [DEV-4415] #601

DaevMithran commented Sep 23, 2024 •

edited

Loading

ankurdotb commented Sep 23, 2024

DaevMithran Oct 1, 2024 •

edited

Loading

ankurdotb Oct 1, 2024 •

edited by DaevMithran

Loading

DaevMithran Oct 1, 2024 •

edited

Loading

ankurdotb Oct 1, 2024

ankurdotb Oct 1, 2024 •

edited by DaevMithran

Loading

ankurdotb Oct 1, 2024

DaevMithran Oct 3, 2024

ankurdotb Oct 1, 2024

ankurdotb Oct 1, 2024

DaevMithran Oct 3, 2024

ankurdotb Oct 1, 2024

DaevMithran Oct 3, 2024

feat: Support DID accreditations [DEV-4415] #601

Are you sure you want to change the base?

feat: Support DID accreditations [DEV-4415] #601

Conversation

DaevMithran commented Sep 23, 2024 • edited Loading

ankurdotb commented Sep 23, 2024

DaevMithran Oct 1, 2024 • edited Loading

Choose a reason for hiding this comment

ankurdotb Oct 1, 2024 • edited by DaevMithran Loading

Choose a reason for hiding this comment

DaevMithran Oct 1, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ankurdotb Oct 1, 2024 • edited by DaevMithran Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DaevMithran commented Sep 23, 2024 •

edited

Loading

DaevMithran Oct 1, 2024 •

edited

Loading

ankurdotb Oct 1, 2024 •

edited by DaevMithran

Loading

DaevMithran Oct 1, 2024 •

edited

Loading

ankurdotb Oct 1, 2024 •

edited by DaevMithran

Loading