Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip broken tests #1074

Merged
merged 6 commits into from
Aug 19, 2022
Merged

skip broken tests #1074

merged 6 commits into from
Aug 19, 2022

Conversation

mikemhenry
Copy link
Contributor

@mikemhenry mikemhenry commented Jul 13, 2022

Description

Skips broken tests.

Motivation and context

Instead of using the envar GITHUB_ACTIONS to conditionally skip these tests, we should just skip them because they are broken. This makes it easier to run tests locally.

Resolves #???

How has this been tested?

Locally and on CI

Change log

No entry needed.


@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Attention: Patch coverage is 97.36842% with 1 line in your changes missing coverage. Please review.

Project coverage is 53.18%. Comparing base (52e324c) to head (72bbde2).
Report is 52 commits behind head on main.

Additional details and impacted files

@mikemhenry
Copy link
Contributor Author

@ijpulidos this is ready for review!

Copy link
Contributor

@ijpulidos ijpulidos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking so long on reviewing this one. Looks good to me! Thanks!

@mikemhenry mikemhenry enabled auto-merge (squash) August 19, 2022 16:56
@mikemhenry mikemhenry merged commit 37da4fb into main Aug 19, 2022
@mikemhenry mikemhenry deleted the fix/skip_broken_tests branch August 19, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants