Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/fix ssl gpu error #1095

Merged
merged 19 commits into from
Sep 6, 2022
Merged

Feat/fix ssl gpu error #1095

merged 19 commits into from
Sep 6, 2022

Conversation

mikemhenry
Copy link
Contributor

Description

Motivation and context

Resolves #???

How has this been tested?

Change log


@mikemhenry
Copy link
Contributor Author

before merging this we will need to change the yaml to run only on merge and not on every commit to the PR

@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #1095 (732d428) into main (2fcd152) will decrease coverage by 1.79%.
The diff coverage is n/a.

@mikemhenry
Copy link
Contributor Author

Updating the image didn't fix it, but I will keep that as-is since it shouldn't hurt things.

@ijpulidos ijpulidos added this to the 0.10.2 Bugfix release milestone Sep 2, 2022
@mikemhenry mikemhenry enabled auto-merge (squash) September 2, 2022 23:08
@mikemhenry
Copy link
Contributor Author

@ijpulidos this is ready for review! I removed the bit where I run the GPU tests on commits to this PR, but you can see that in the previous run we have a green check and that includes the GPU tests

Copy link
Contributor

@ijpulidos ijpulidos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, LGTM!

@mikemhenry mikemhenry merged commit aa929f1 into main Sep 6, 2022
@mikemhenry mikemhenry deleted the feat/fix_ssl_gpu_error branch September 6, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants