Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the faster LangevinDynamicsMove #1138

Merged
merged 2 commits into from
Jan 10, 2023
Merged

Conversation

ijpulidos
Copy link
Contributor

Description

We should be using the faster LangevinDynamicsMove by default in our CLI workflow.

Tests and test systems were also updated to reflect the changes.

Motivation and context

Increase performance by using the faster LangevinMiddleIntegrator.

Resolves #1137

How has this been tested?

Change log

CLI workflow for replica exchange now uses the faster ``LangevinMiddleIntegrator`` via the ``LangevinDynamicsMove``. Tests were updated to reflect the changes. 

@ijpulidos ijpulidos added this to the 0.10.2 Bugfix release milestone Jan 6, 2023
@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Merging #1138 (deeadd7) into main (1dc9b86) will not change coverage.
The diff coverage is 20.00%.

Copy link
Member

@jchodera jchodera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ijpulidos
Copy link
Contributor Author

ijpulidos commented Jan 10, 2023

I just wanted to make sure that the new integrator wouldn't change anything in our benchmarks, just me being cautious. We get the same results with our tyk2 benchmark (this one hasn't fully run the 5ns that's why it has somewhat big error bars, but it should be okay)

image

In terms of the performance gain, I was able to obtain about a 20% increase for the solvent phase and about a 9% increase for the complex phase.

So this should be good to merge :).

@ijpulidos ijpulidos merged commit 21c1ed1 into main Jan 10, 2023
@ijpulidos ijpulidos deleted the 1137-use-LangevinDynamicsMove branch January 10, 2023 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI repex should use LangevinDynamicsMove
2 participants