Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow generate_dipeptide_top_pos_sys to accept demap_CBs #892

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

zhang-ivy
Copy link
Contributor

Description

This PR piggy backs off of #860, where I forgot to allow demap_CBs to be passed to generate_dipeptide_top_pos_sys.

Motivation and context

This is necessary because to enable generating protein mutation test systems with demapped CBs.

How has this been tested?

Change log


@zhang-ivy
Copy link
Contributor Author

@mikemhenry @ijpulidos : could you review and merge?

Copy link
Contributor

@ijpulidos ijpulidos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! good catch. This looks just fine. Thanks!

@ijpulidos
Copy link
Contributor

@zhang-ivy This might be for another issue/PR, but just wondering if we have tests for this case. Such as a test that requires demap_CBs=True for it to pass. Thoughts? (I guess it is related to the #845 , maybe we can engineer some test around that case).

@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #892 (e82e60b) into master (64da9aa) will decrease coverage by 0.94%.
The diff coverage is 100.00%.

@zhang-ivy
Copy link
Contributor Author

@zhang-ivy This might be for another issue/PR, but just wondering if we have tests for this case. Such as a test that requires demap_CBs=True for it to pass. Thoughts? (I guess it is related to the #845 , maybe we can engineer some test around that case).

Yes, it couldn't hurt to have another test that checks whether demap_CBs actually demaps the CBs. Would you want to take a stab at this? It should be something like this: choderalab -- but would just have to change the reference map to not include CBs.

@ijpulidos ijpulidos merged commit a5d6341 into master Nov 12, 2021
@ijpulidos ijpulidos deleted the fix-generate-dipeptide branch November 12, 2021 15:50
@mikemhenry mikemhenry mentioned this pull request Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants