Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test for ROC mіsmatch #725

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

fippo
Copy link
Contributor

@fippo fippo commented Sep 30, 2024

illustrating the reason why one should carefully pick the initial sequence number low enough to avoid a rollover.

See
https://webrtc-review.googlesource.com/c/src/+/358360

@fippo fippo force-pushed the roc-mismatch-test branch 2 times, most recently from 18da4a4 to 8b4f99f Compare September 30, 2024 02:55
illustrating the reason why one should carefully pick the initial
sequence number low enough to avoid a rollover.

See
  https://webrtc-review.googlesource.com/c/src/+/358360
@fippo
Copy link
Contributor Author

fippo commented Sep 30, 2024

Quite interesting that not everything fails... it fails when using OpenSSL but not in "normal" / builtin mode?!
The reason for the failure is that the failed attempt to unprotect modifies pkt1 and pkt2 which is quite surprising.

Avoided by modifying the test slightly, see second commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant