(Backport) CRM-20675 - Fix incorrect renewal activity created when membership updated via API #10598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this makes the test pass seems ok to me to merge |
jitendrapurohit
approved these changes
Jul 4, 2017
|
merged per @seamuslee001 & @jitendrapurohit feedback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@eileenmcnaughton pointed out that
4.7.21-rchas a failing test. The testwas already failing at the time we branched off of
master, but it wassubsequently fixed in
mastervia #10457.This is a backport of #10457 from
masterto4.7.21-rc.I haven't investigated the merits of the issue - ping @eileenmcnaughton,
@monishdeb, @jitendrapurohit for feedback.