Throw exception instead of using fatal #11719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duplicate contributions are a really not handled well anywhere in the form layer. The CRM_Core_Error winds up using the fatal template, which has the same end result for form users as if an exception were thrown, let's switch. Note that this appears to be the only scenario when an error would be returned so we can simply drop that handling
eileenmcnaughton
force-pushed
the
fatal
branch
from
295d44b
to
77beddb
Compare
|
Looks like a sensible, safe change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Minor code improvement - use exception rather than fatal
Before
CRM_Core_Error::fatal($message); shows the below regardless of whether debugging is enabled
After
Technical Details
In general we are working towards deprecating 'fatal' - in this case we can convert it to an exception & add handling to the exception to improve user experience
Comments
Note that I replicate this error when debugging but have not seen the duplicate contribution error 'out in the wild' - to replicate in debugging start doing a contribution, kill half way through & then re-submit.
@colemanw @seamuslee001 @monishdeb would be good to get your thoughts on this (ps. I bet @mattwire has hit this error!)