Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CiviReport - Check for trueish values of the parameter 'required' #11725

Merged
merged 1 commit into from
Feb 27, 2018

Conversation

tschuettler
Copy link
Contributor

Overview

The value of the parameter required is not evaluated to define whether the field should be shown as required or not.

See previous discussion at: civicrm/civicrm-dev-docs#480

Before

'id' => array(
  'title' => ts('CiviCRM ID'),
  'default' => TRUE,
  'required' => FALSE,
),

grafik

After

'id' => array(
  'title' => ts('CiviCRM ID'),
  'default' => TRUE,
  'required' => FALSE,
),

grafik

@eileenmcnaughton
Copy link
Contributor

There is quite a lot of related discussion supporting this change in the docs link above. Merge on pass

@monishdeb
Copy link
Member

Merging as per tag

@monishdeb monishdeb merged commit 52ee38e into civicrm:master Feb 27, 2018
@mlutfy mlutfy added this to the 4.7.32 milestone Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants