CRM-21391 Convert Mailing to use core Task class #11761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm merging this based on reading the code & the similarity between this & related changes. This one is the easiest of them to grok so I feel OK based on just reading but assuming the rc is cut soon I'll also test the rc on a live site |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Refactor mailing task form to use base class
Before
Mailing tasks don't seem to be exposed anywhere in UI
After
Mailing tasks don't seem to be exposed anywhere in UI
Technical Details
details in #11240
Comments
This is a commit from #11240
In terms of review check that the code was a positive improvement and tested a couple of actions as well as checking the same number of actions were present