CiviMember: use fa-ban, proper crm-i class for canceled auto-renew

[agh1]

Overview

In CRM-21688, icons display the status of auto-renew for memberships. This uses the proper class for CiviCRM's implementation of Font Awesome and changes the icon for canceled auto-renewals.

Before

The icons use the fa class, which is the standard class for Font Awesome icons. However, this could result in problems with CMS themes that have their own implementations of Font Awesome.

Also, the icon for canceled auto-renewals is fa-exclamation, which implies that something has gone wrong with the autorenewal and needs immediate attention.

After

The icons use the crm-i class, which explicitly uses CiviCRM's Font Awesome library.

The icon for canceled auto-renewals is fa-ban, an icon that more closely expresses that the member has canceled their autorenewal.

Comments

I'm not sure, but I don't think that CiviCRM's Font Awesome responds to the fa class at all, which means that the icons would be missing if a site lacks a separate Font Awesome implementation. @colemanw do you know? If that's the case, I think this might need to be a last-minute merge to the 4.7.31 RC. Never mind, I just checked and it appears okay on dmaster.

---

• CRM-21688: Use fontawesome to show membership auto-renew status and and error indicator

[colemanw]

This is simple and straightforward.