Remove hacks from CRM_Core_Menu for old unsupported versions #11781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colemanw
changed the title
|
@michaelmcandrew Can you review? |
totten
changed the title
|
@mattwire - how come you thought of me for this? I don't think I would be much use - I don't have any experience in this part of civi :) |
|
@totten can you verify this one? |
|
I read through this code and feel confident that it is a safe cleanup. The code removed is very specific to things we no longer need to support per notes above |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Removes unused variables and old unsupported hacks that were needed in ancient times.
Before
Clutter.
After
-18 lines of clutter.
Technical Notes
Currently CiviCRM 4.7 does not support directly upgrading from any version prior to 4.1. So all upgrade code for previous versions should be removed. I had already gotten rid of most of it, here are few stragglers.