Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs CRM-21837 - Missing states for Gabon #11793

Merged
merged 1 commit into from
Mar 9, 2018
Merged

Conversation

cor73x
Copy link
Contributor

@cor73x cor73x commented Mar 9, 2018

Overview

Adds missing states definition for Gabon based on current ISO standard.

Before

Current codebase is missing Gabon states. User is not able to select this in state/province field.

After

Gabon states are available to select by user.

Technical Details

Database is updated to contain regions for Gabon according to ISO Standard.
According to ISO standard Gabon has 9 states:
https://www.iso.org/obp/ui/#iso:code:3166:GA
https://en.wikipedia.org/wiki/ISO_3166-2:GA
I have added them all to 4.7.32 update file.

Comments

Refs https://issues.civicrm.org/jira/browse/CRM-21837

@civicrm-builder
Copy link

Can one of the admins verify this patch?

@seamuslee001
Copy link
Contributor

Jenkins test this please

@seamuslee001
Copy link
Contributor

This looks correct to me @mlutfy can you confirm?

@mlutfy
Copy link
Member

mlutfy commented Mar 9, 2018

Yep, I agree.

(CiviCRM Review Template WORD-1.0)

  • (r-test) ✔ n/a, only adds options to existing mechanism.
  • (r-code) ✔ install & upgrade code is there.
  • (r-doc) ✔ n/a Only adds options, no doc required.
  • (r-maint) ✔ n/a Only adds options, won't affect tech debt.
  • (r-run) ✔ tested the c-i demo
  • (r-user) ✔ won't cause behaviour changes.
  • (r-tech) ✔n/a, no impact

@mlutfy mlutfy merged commit 8783e79 into civicrm:master Mar 9, 2018
@mlutfy mlutfy modified the milestones: 4.7.33, 4.7.32 Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants