Update test to NOT accept a failure in the api call. #11798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe the failure handling exists because this was copied from a test that uses a real payment gateway's sandbox account, hence intermittant failure. However, we don't need that for the Dummy processor & it's making debugging hard
|
This only affects tests and the unit tests passed so i believe this can be safely merged |
|
thanks @seamuslee001 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
A brief description of the pull request. Try to keep it non-technical.
Before
Test passes
After
Test passes
Technical Details
I believe the failure handling exists because this was copied from a test that
uses a real payment gateway's sandbox account, hence intermittant failure.
However, we don't need that for the Dummy processor & it's making debugging hard
Comments
@samuelsov I believe merging this will make it possible to make sense of test fail on #10377