(dev/core#255) Changes to copied event location reflects in original …

[yashodha]

…event location

Overview

Steps to replicate:

1. Create an event X with location A.
2. Create copy of event X say Y and go to location tab for event Y (which will now show location A).
3. Click Create new location radio and then click Use existing location, choose option B.
4. Check event X also has location B.

Before

changed event location rather than create new location - original event location gets changed as well.

After

only copied event location gets changed.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[yashodha]

@lcdservices Can you please confirm the same as you fixed this in #12104

[lcdservices]

@yashodha @eileenmcnaughton I reviewed and this looks good. I ran through the testing steps prior to applying the PR and could reproduce the issue. I then applied the PR and confirmed the new/copied event's location does not affect the original event.

[yashodha]

@lcdservices thanks!

[kngs]

It fixed for me on one Joomla site. It still doesn't work on another site but it has other javascript (backbone) issues so might still be causing conflicts. But good on first! Thank you :)

[eileenmcnaughton]

thanks for the quick & clear review @lcdservices & for the patch @yashodha