BAO_Navigation: Respect domain_id param

[colemanw]

Overview

Allow choosing the domain_id when creating or updating a navigation menu item

Before

The BAO would clobber the domain_id whenever creating or updating a navigation menu item.

After

It respects the param if set, but will still default to the current domain.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

@colemanw i think this could use a unit test along the lines of https://github.com/civicrm/civicrm-core/pull/12461/files#diff-e5624ebe1685e34bff25d0d0e5463d4cR131 ping @eileenmcnaughton

[mattwire]

• Old logic: Always set default domain_id.
• New logic: If creating a new entity, prefer the domain_id passed in via $params. Fallback to default domain_id. If updating, don't touch the domain_id (unless passed in via $params in which case it will be used).

This looks good, if we could add a unit test per @seamuslee001 suggestion I'm happy for it to be merged.

[colemanw]

@mattwire @seamuslee001 thanks for the review. I've added a simple test for api3, and will be adding more robust testing for this in the api4 extension.