Fix regression on case export from recent export fix #12517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
civicrm@3b4adc9 changed the way componentmode is defined It now seems inconsistent
eileenmcnaughton
force-pushed
the
case_export_fail
branch
from
9515b21
to
d5fd18f
Compare
|
tested and confirmed. this fixes the undefined property warnings. |
|
@lcdservices adding merge on pass on your review - did you check 5.4? I thought it wasn't there but also thought my head was spinning after looking at this for a while |
|
I tested against the master branch and could reproduce. After applying the PR the error was removed. |
|
👍 |
|
@mattwire do you think 5.4 is affected? |
|
@eileenmcnaughton Yes looks like 5.4 is affected :-( #12316 and #12320 will need to be backported before this PR can be applied to 5.4 though. |
|
@mattwire can you do a backport PR for 5.4? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix enotices & fatal error on case export
Before
After
Technical Details
I experienced a lot of inconsistency in my testing of this & switching to a component specific class that extended the main one seemed much more reliable - and as a approach it offers the possibility of much cleaner code
Comments
I don't think this affects 5.4 rc
@mattwire @lcdservices @kcristiano ping