Move relationship return properties to the processor class to fix leakage related test fail #12521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
fix_im_export_test
branch
3 times, most recently
from
48e9237
to
a7dec79
Compare
|
@eileenmcnaughton syntax error |
|
@seamuslee001 ug - just rebased - 2 secs let me try again |
eileenmcnaughton
force-pushed
the
fix_im_export_test
branch
from
a7dec79
to
dd69b0f
Compare
…kage related test fail
eileenmcnaughton
force-pushed
the
fix_im_export_test
branch
from
dd69b0f
to
704e3e9
Compare
| @@ -611,9 +611,6 @@ public function testExportIMData() { | |||
| } | |||
| } | |||
|
|
|||
| // early return for now until we solve a leakage issue. | |||
| return; | |||
There was a problem hiding this comment.
removing this enables a lot of coverage
|
Tested on my local, works fine. Did export with various use-cases, didn't encountered any issue. Tests passed. Happy with the patch, merging now |
|
thanks! @monishdeb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Code rejigging to support increased testing
Before
Part of im_provider test didn't work except in isolation due to leakage
After
Full test enabled & passes
Technical Details
Now we have the ExportProcessor class moving properties that should be OO onto it solves a catalogue of woes
Comments
The newly enabled test covers this code change very thoroughly