Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to option group page from option group menu item #12540

Merged
merged 1 commit into from
Jul 24, 2018

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Jul 23, 2018

Overview

Adds a link to a page that is otherwise very hard to find.

Before

Can't directly get to the "Option Groups" page.

After

Menu item which looks like it ought to link to it, does in fact link to it.

@civibot
Copy link

civibot bot commented Jul 23, 2018

(Standard links)

@colemanw
Copy link
Member Author

@mattwire this is a follow up to #12473. Can you give feedback on this one please?

@mattwire
Copy link
Contributor

@colemanw Don't you have access to it via Administer->System Settings->Option Groups?

What you are proposing might be more sensible, as "Option Groups" is a little out of place in System Settings but it's there on all my installs.

@colemanw
Copy link
Member Author

Huh. I never noticed that there before!
But it doesn't have to be "either/or" -- we can add this without taking anything else away.

@eileenmcnaughton
Copy link
Contributor

Unrelated fail. I think this is fine as an additional link

@eileenmcnaughton eileenmcnaughton merged commit 34169ad into civicrm:master Jul 24, 2018
@eileenmcnaughton eileenmcnaughton deleted the Link branch July 24, 2018 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants