Update navigation menu items to use FontAwesome #12541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
@omarabuhussein @AkA84 @jamienovick I noticed that Shoreditch messes up the menu icons when not in full override mode. I've posted a followup PR to remove the now unnecessary script which was swapping out the icon images, as this PR now does that. |
|
I agree Shoreditch usability is improved by this (when not using override). Before |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This updates the menu "caret" icon to use FontAwesome instead of an image file.
Before
Unnecessary image loading, caused problems with Shoreditch.
After
Menu looks the same, but works better with Shoreditch and icon is a bit sharper.