Upgrader - When updating message templates, identify them by name #12674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: Fix a layout issue caused by a typo in the `<li>` tag.
|
(Standard links)
|
|
I tested this & it works - as an aside both links go to the old wiki not our docs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When updating message templates, identify them by name. This resolves confusion in the upgrade UI for sites passing through/to v5.4.
Also: Fix a layout issue caused by a typo in the
<li>tag.Before
(Screenshot from @Stoob's original report.)
After
(Screenshot from a local upgrade prepared for 5.3.x=>5.5.beta1)
Comments
This doesn't make any change to the substantive upgrade logic -- it's just addresses a presentational issue.