Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WordPress support for Get UF Locale #16700

Merged
merged 1 commit into from
Apr 2, 2020

Conversation

christianwach
Copy link
Member

@christianwach christianwach commented Mar 6, 2020

Overview

This PR completes #16289 and solves the issue on Lab. In essence, CiviCRM only displays in the default CiviCRM language, whether on the front-end or in WordPress admin.

Before

When "Inherit language" is selected, CiviCRM only displays in the default language set in CiviCRM, whether on the front-end or in WordPress admin.

After

When "Inherit language" is selected, the logic that CiviCRM now follows is that:

  • CiviCRM's admin screens are displayed in the language that the WordPress User has chosen on their Profile screen, since this is what the rest of the WordPress admin displays to them. If they inherit their language from WordPress, then that is used.
  • CiviCRM's front-end forms default to the language that WordPress is set to.
  • CiviCRM's front-end forms respect the language that multilingual plugins report.

@civibot
Copy link

civibot bot commented Mar 6, 2020

(Standard links)

@civibot civibot bot added the master label Mar 6, 2020
@mattwire
Copy link
Contributor

mattwire commented Mar 6, 2020

I've got this on my site now for testing - so far so good! @christianwach it's failing on 10 style warnings - can you fix?

@christianwach
Copy link
Member Author

it's failing on 10 style warnings

@mattwire Have force pushed fixes -- let's see how the checks pan out.

@jaapjansma
Copy link
Contributor

test this please

@christianwach
Copy link
Member Author

Anyone have any ideas why the checks are failing? I see nothing amiss when I look at the details.

@kcristiano
Copy link
Member

jenkins test this please

@kcristiano
Copy link
Member

I restarted the test as I know there have been some oddities lately.

@seamuslee001
Copy link
Contributor

Jenkins re test this please

@kcristiano
Copy link
Member

This looks merge-ready to me

@kcristiano kcristiano added the merge ready PR will be merged after a few days if there are no objections label Apr 2, 2020
@mattwire
Copy link
Contributor

mattwire commented Apr 2, 2020

Thanks @kcristiano @christianwach

@mattwire mattwire merged commit e752e98 into civicrm:master Apr 2, 2020
@christianwach christianwach deleted the lab-1635 branch April 2, 2020 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master merge ready PR will be merged after a few days if there are no objections ok-without-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants