Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FinancialTrxn.php #16964

Merged
merged 1 commit into from
Apr 3, 2020
Merged

Update FinancialTrxn.php #16964

merged 1 commit into from
Apr 3, 2020

Conversation

GuillaumeSorel
Copy link
Contributor

PAN is an acronym for Primary Account Number (credit card number) and writing it full in uppercase will make it more obvious for people to translate as I really wondered even with context what it meant.

Overview

A brief description of the pull request. Keep technical jargon to a minimum. Hyperlink relevant discussions.

Before

What is the old user-interface or technical-contract (as appropriate)?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.

After

What changed? What is new old user-interface or technical-contract?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.

Technical Details

If the PR involves technical details/changes/considerations which would not be manifest to a casual developer skimming the above sections, please describe the details here.

Comments

Anything else you would like the reviewer to note

PAN is an acronym for Primary Account Number (credit card number) and writing it full in uppercase will make it more obvious for people to translate as I really wondered even with context what it meant.
@civicrm-builder
Copy link

Can one of the admins verify this patch?

@civibot
Copy link

civibot bot commented Apr 3, 2020

(Standard links)

@civibot civibot bot added the master label Apr 3, 2020
@mattwire
Copy link
Contributor

mattwire commented Apr 3, 2020

@mlutfy This makes sense to me, and for you?

@mlutfy
Copy link
Member

mlutfy commented Apr 3, 2020

Yep.

We normally want to avoid breaking translation strings, but this string is from the new-ishly added DAO strings, which are often terrible (since they were not exposed publicly until more recently).

Merci @GuillaumeSorel !

@mlutfy mlutfy merged commit 4fe682f into civicrm:master Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants