[REF] Formatting and use bool instead of boolean #17012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
demeritcowboy
commented
Apr 7, 2020
•
demeritcowboy
commented
- Casts which have an extra space.
- The standard is bool instead of boolean.
- Remove unnecessary casts.
- Unnecessary line break.
|
(Standard links)
|
colemanw
reviewed
Apr 7, 2020
colemanw
reviewed
Apr 7, 2020
|
Ok good thinking - will update. Maybe somebody put the spaces in the casts as a primitive way of signalling "todo"... No, probably not. |
|
That would be very clever indeed. |
demeritcowboy
changed the title
colemanw
reviewed
Apr 7, 2020
| @@ -88,7 +88,7 @@ public function process($xml, &$params) { | |||
| // create relationships for the ones that are required | |||
| foreach ($xml->CaseRoles as $caseRoleXML) { | |||
| foreach ($caseRoleXML->RelationshipType as $relationshipTypeXML) { | |||
| if ((int ) $relationshipTypeXML->creator == 1) { | |||
| if ($relationshipTypeXML->creator) { | |||
| if (!$this->createRelationships($relationshipTypeXML, | |||
| $params | |||
| ) | |||
There was a problem hiding this comment.
Boy you could really get sucked into making this file better. This conditional has some strange line-breaks that I would get rid of... and the return FALSE; below is unreachable after calling CRM_Core_Error::fatal();. And of course we should be throwing exceptions instead of using that function anyway... where to stop?
There was a problem hiding this comment.
I know the feeling. Beer solves it temporarily.
There was a problem hiding this comment.
Since there were some weird test fails anyway I updated those line breaks too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.