Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIv4 - Add support for HAVING clause #17015

Merged
merged 1 commit into from
Apr 8, 2020

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Apr 8, 2020

Overview

Allows the APIv4 query to have a HAVING clause.

Technical Details

Fields referenced in the HAVING clause must be in the SELECT clause as well (HAVING can reference them by their name or alias if used for expressions).

Comments

TODO: Make it look nice in the API Explorer.

@civibot
Copy link

civibot bot commented Apr 8, 2020

(Standard links)

@eileenmcnaughton
Copy link
Contributor

My key criteria for adding additional functions to apiv4 is that they are tested. Our existing test cover gives me some confidence about avoiding breakage

@eileenmcnaughton eileenmcnaughton merged commit 9c10827 into civicrm:master Apr 8, 2020
@eileenmcnaughton eileenmcnaughton deleted the having branch April 8, 2020 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants