Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] Remove calculation of unused parameter #17093

Merged
merged 1 commit into from
Apr 20, 2020
Merged

[NFC] Remove calculation of unused parameter #17093

merged 1 commit into from
Apr 20, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Apr 17, 2020 •
edited
Loading

Overview

Removes a call to define an unused parameter

Before

Screen Shot 2020-04-17 at 3 00 54 PM

After

poof

Technical Details

The getfields function doesn't receive anything by reference

Comments

@civibot
Copy link

civibot bot commented Apr 17, 2020

(Standard links)

@civibot civibot bot added the master label Apr 17, 2020
@demeritcowboy
Copy link
Contributor

Agreed. The call to getFields might have the effect of prepopulating a cache, but that can't possibly be its purpose.

@pradpnayak
Copy link
Contributor

looks good to merge

@mattwire
Copy link
Contributor

Merging based on @demeritcowboy @pradpnayak review

@seamuslee001 seamuslee001 merged commit 178b7e3 into civicrm:master Apr 20, 2020
@seamuslee001 seamuslee001 deleted the cont branch April 20, 2020 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eileenmcnaughton @demeritcowboy @pradpnayak @mattwire @seamuslee001