Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#1780 Fix bug where non-household merge contacts were being skipped #17462

Merged
merged 1 commit into from
Jun 2, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Fixes a bug where exporting a child and their parent was only resulting in one row being exported, when the related contact id was selected

Before

Per https://lab.civicrm.org/dev/core/-/issues/1780

After

Per https://lab.civicrm.org/dev/core/-/issues/1780

Technical Details

Comments

@yashodha this should do it

@civibot
Copy link

civibot bot commented Jun 2, 2020

(Standard links)

@civibot civibot bot added the 5.26 label Jun 2, 2020
@eileenmcnaughton
Copy link
Contributor Author

test this please

@yashodha
Copy link
Contributor

yashodha commented Jun 2, 2020

@eileenmcnaughton
2 rows are now shown correctly. However, spouse contact id for the 1st contact is missing
export

@eileenmcnaughton
Copy link
Contributor Author

@yashodha hmm - we can merge this to hit the rc & punt that for now I think as I don't see that getting fixed in time

@yashodha
Copy link
Contributor

yashodha commented Jun 2, 2020

@eileenmcnaughton yes, I agree. This works and can be merged.

@yashodha yashodha merged commit 7b1b330 into civicrm:5.26 Jun 2, 2020
@eileenmcnaughton eileenmcnaughton deleted the 526ex branch June 2, 2020 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants