dev/core#2034 Fix paypal standard cancel url #18540
Merged
+18
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
Will add this to my UI test |
|
thanks @pradpnayak |
Per https://lab.civicrm.org/dev/core/-/issues/2034 the wrong urls are included in paypal standard emails for cancellation I think this likely regressed a long time ago - but the symptoms changed a little this year - so I am just putting against master
eileenmcnaughton
force-pushed
the
paypal
branch
from
f4c1d2a
to
4f2c0e2
Compare
|
test this please |
1 similar comment
|
test this please |
|
@pradpnayak did you get to this? Could be worth testing in conjunction with #18536 (If you can't get to it let me know & I'll try to track down someone else) |
|
@colemanw @seamuslee001 could one of you merge this - the reporter has tested ... and there are follow on issues in a separate PR
|
|
Merging as per the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Per https://lab.civicrm.org/dev/core/-/issues/2034 the wrong urls are included in paypal standard emails for cancellation
I think this likely regressed a long time ago - but the symptoms changed a little this year - so I am just putting
against master
Before
Email contains civicrm urls
This is a recurring contribution.
You can cancel future contributions at:
http://dmaster.local/civicrm/contribute/unsubscribe?reset=1&coid=98
After
Email contains paypal urls for paypal standard processor
https://www.sandbox.paypal.com/cgi-bin/webscr?cmd=_subscr-find
Technical Details
Overriding the parent class to provide the correct url for the processor
Comments