Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] - Fix some tests to call API not BAO #18795

Merged
merged 1 commit into from
Oct 19, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Oct 19, 2020

Overview

Towards eliminating direct BAO calls like CRM_Member_BAO_Membership::create

Before

CRM_Member_BAO_Membership::create()

After

$this->callAPISuccess('Membership', 'create', $params);

Technical Details

We don't have a v4 membership api yet - mostly because it needs preliminary cleanup so using v3

Comments

@civibot
Copy link

civibot bot commented Oct 19, 2020

(Standard links)

@civibot civibot bot added the master label Oct 19, 2020
@seamuslee001
Copy link
Contributor

Looks fine to me merging

@seamuslee001 seamuslee001 merged commit 300720c into civicrm:master Oct 19, 2020
@seamuslee001 seamuslee001 deleted the api branch October 19, 2020 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants