SavedSearch - Add name and label columns

[colemanw]

Overview

Adds 2 database columns: name and label for the SavedSearch entity.
This is needed by the new Search Kit extension.

Before

SavedSearch entity lacks unique name or label.
Pre/post hooks not called for SavedSearch entity.

After

Label column added for identifying saved search on administrative screens.
Unique name column added for embedding savedsearch displays by name on pages, dashlets, etc.
Pre/post hooks called.

Technical Details

Unique name generated from label if not supplied.
Switching from ad-hoc create function to the standard dao::writeRecord ensures that hooks are properly called.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

@seamuslee001 @eileenmcnaughton @totten this is going to go stale real fast.

[demeritcowboy]

Does this need "localizable"?

[colemanw]

No I don't think so. This is intended for back-end administration screens.

[colemanw]

Test fails were being caused by the sloppy function CRM_Contact_BAO_Group::createSmartGroup(). I cleaned it up to fix the failures, but it's currently only ever used by tests, so we could delete it and refactor the tests to use something else, or move it into the test class and out of the BAO.

[colemanw]

@eileenmcnaughton I forgot to add the unique index to the upgrader. Looking at the function CRM_Upgrade_Incremental_Base::addIndex() it doesn't appear capable of creating a UNIQUE index.
But I see there's also a function CRM_Core_BAO_SchemaHandler::createMissingIndices() which looks like it would automatically add the index based on the schema... but I don't see it being called from the upgrader? Is it ever called routinely, or only manually?

[eileenmcnaughton]

@colemanw only manually