Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hack away at false negative test fails #18892

Merged
merged 1 commit into from
Oct 31, 2020
Merged

Hack away at false negative test fails #18892

merged 1 commit into from
Oct 31, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Oct 30, 2020 •
edited
Loading

Overview

Nasty but effective way to reduce false fails on the test suite

Before

see https://test.civicrm.org/job/CiviCRM-Core-PR/37737/testReport/junit/api.v4.Entity/ConformanceTest/testConformance_with_data_set__UFField_/

After

poof

Technical Details

Comments

@civibot
Copy link

civibot bot commented Oct 30, 2020

(Standard links)

@civibot civibot bot added the master label Oct 30, 2020
@eileenmcnaughton eileenmcnaughton mentioned this pull request Oct 30, 2020
Merged
@colemanw colemanw merged commit b681360 into civicrm:master Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @colemanw