Fix fatal error on payment edit form #19091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
seamuslee001
reviewed
Dec 3, 2020
| foreach ($moneyFields as $field) { | ||
| $defaults[$field] = CRM_Utils_Money::formatLocaleNumericRoundedForDefaultCurrency($this->_values[$field]); | ||
| } | ||
| $defaults['total_amount'] = CRM_Utils_Money::formatLocaleNumericRoundedForDefaultCurrency($this->_values['total_amount']); |
There was a problem hiding this comment.
@eileenmcnaughton is the gist that fee_amount and net_amount aren't exposed on this form or something?
There was a problem hiding this comment.
@seamuslee001 yep
|
I r-runed this on my local and it works and the changes make sense as well MOP |
|
Merged base on @seamuslee001 testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes a fatal error when editing a payment
Before
fatal error / network error when editing a payment from here
After
works
Technical Details
For what looks like copy & paste reasons defaults are loaded for 2 fields that are not on the form -net_amount & fee_amount. The switch to brick money caused passing in NULL for these to result in fatal errors.
While a case could be made to add fee amount to the form this just adjusts the form to be correct for the fields already there
Comments
@seamuslee001