-
-
Notifications
You must be signed in to change notification settings - Fork 812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev/core#2793 - Add REGEXP/NOT REGEXP SQL operators #21288
Conversation
(Standard links)
|
This comment has been minimized.
This comment has been minimized.
a6cc231
to
89c338e
Compare
d3741d9
to
0d8f879
Compare
@pfigel this looks great. One question though: if case-sensitivity has been solved in the SQL functions front, should we remove the |
@colemanw Good question. If we include I'd say: Include |
I say remove it. You can always build insensitivity into your regex if you need it (e.g. |
This adds the REGEXP and NOT REGEXP operators to API4 and SearchKit.
0d8f879
to
b5599ad
Compare
That makes sense - should be good now. |
Just noting that this does affect SearchKit. I presume that users who don't know what "Matches Regexp" means will stay away from it. |
Overview
This adds the
REGEXP
andNOT REGEXP
operators to API4 and SearchKit.Before
REGEXP
/NOT REGEXP
were not usable as operators in API4 or SearchKit.After
REGEXP
/NOT REGEXP
can be used as operators in API4 and SearchKit.Technical Details
Some questions re: case-sensitivity in https://lab.civicrm.org/dev/core/-/issues/2793; solved via #21301