[NFC/Unit test] - Fix secondary issue with case token consistency test

[demeritcowboy]

Overview

Intermittently failing test

Before

e.g.

CRM_Utils_TokenConsistencyTest::testCaseTokenConsistency
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
 Ongoing\n
 No\n
 2021-09-04 06:22:17\n
-2021-09-04 06:22:17\n
+2021-09-04 06:22:18\n
 '

After

Technical Details

api3 case create calls CRM_Case_BAO_Case::create to create the Case record, and stores it in $caseBAO. It then calls the xmlprocessor to populate the timeline, which via activity triggers updates case.modified_date. Then it returns the $caseBAO from before that as the api result. If there's a split-second delay then $caseBAO['modified_date'] won't match the latest modified_date, which is what the evaluated token uses.

Comments

Is test

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

Good detective work!