dev/core#2823 update function visibility to protected #21412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes some internal functions 'protected'. I did a universer search for them. Making them protected means that when I look to clean them up it is clear that we only need to worry about how the class interacts with them
|
(Standard links)
|
|
Agreed, these functions are definitely internal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
dev/core#2823 update function visibility to protected
This makes some internal functions 'protected'
Before
public
After
protected
Making them protected means that when I look to clean them up it is
clear that we only need to worry about how the class
interacts with them
Technical Details
Comments
I did a universe search for them.