Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove error handling for core error being returned #21425

Merged
merged 1 commit into from
Sep 10, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

This would be throwing an exception - also it isn't an error situation

Overview

Remove error handling for core error being returned

Before

Handling for returned CRM_COre_Error

After

poof

Technical Details

Remove error handling for core error being returned

Comments

We have lots of places like this but there are very few functions that actually return core errors these days.... history

This would be throwing an exception - also it isn't an error situation
@civibot
Copy link

civibot bot commented Sep 9, 2021

(Standard links)

@demeritcowboy
Copy link
Contributor

Agree. Even if it returned an Error from apiQuery the reset() on the next line turns it into an array, and then the next few lines ensure the if will always be false.

@eileenmcnaughton eileenmcnaughton merged commit c53e7a2 into civicrm:master Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants