dev/core#2829 - unit test for nonempty dashboard

[demeritcowboy]

Overview

https://lab.civicrm.org/dev/core/-/issues/2829

Test demonstrating dashboard fail.

My only question is whether $explicitJoin['bridge'] in Api4SelectQuery is expected to always be set or whether it's ok that it's missing. I'm thinking the latter.

Before

What is the old user-interface or technical-contract (as appropriate)?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.

After

What changed? What is new old user-interface or technical-contract?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.

Technical Details

If the PR involves technical details/changes/considerations which would not be manifest to a casual developer skimming the above sections, please describe the details here.

Comments

Anything else you would like the reviewer to note

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@demeritcowboy was this meant to fail? or is the fix already merged?

[demeritcowboy]

Oh, it failed to fail because the test node is php 7.2. It succeeds in failing on 7.4.

[eileenmcnaughton]

lol ok - I'll merge & it can fail as successfully as it can

[demeritcowboy]

Thanks.
You can see now on the MAX matrix tests it fails to not fail and you get the same stack trace as in the lab ticket: https://test.civicrm.org/job/CiviCRM-Core-Matrix/10039/BKPROF=max,CIVIVER=master,SUITES=phpunit-crm,label=bknix-tmp/testReport/junit/(root)/CRM_Core_InvokeTest/testInvokeDashboardWithGettingStartedDashlet/

Fix is at #21441

[eileenmcnaughton]

Does is succeed in succeeding while failing to not fail?

[demeritcowboy]

Well, this outputs "yes".

$failure = 0;
$success = 1;
if ($failure = $success) {
  echo 'yes!';
}

He he.

[eileenmcnaughton]

My brain just broke