dev/core#2823 fix test to be more like real function usage

[eileenmcnaughton]

Overview

dev/core#2823 fix test to be more like real function usage

Before

The construct function on ManagedEntities takes 2 parameters :

$modules
$declarations

Outside of tests there is no variation in the values of these ie they are always launched from the singleton

Which always passes 'allModules' and NULL

Ergo the variables only exist to support tests

After

The second variable is removed - tests now emulate the 'real world' scenario of using a hook to declare 'managed'

We also get rid of the silly variable name 'decls'

Technical Details

I expect that it's fairly tricky to mock the modules being installed via the tests & hence the first variable probably makes sense & led to the second which seems to just add confusion

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

Cool. Tests are happy, lets see if it fixes the failing Afform tests.