[Ref] Extend email trait test, process more sanely #21553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eileenmcnaughton
force-pushed
the
email2
branch
from
ace6c04
to
1cf4e22
Compare
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
email2
branch
from
1cf4e22
to
5c93f9c
Compare
eileenmcnaughton
force-pushed
the
email2
branch
2 times, most recently
from
68c534a
to
da388f9
Compare
This extracts the code used to get the from values, moves the default setting to the default and adds a test. The goal is actually to add a test on the submit function but it's proving to be challenging so this at least gets the default setting tested. Note that this code used to be on a static class, not a trait, and some stuff is in weird places - in particular stuff that should be in setDefaults and postProcess is happening on preProcess. However, most of the classes that override this trait do not do much more than call the trait so that helps at least
eileenmcnaughton
force-pushed
the
email2
branch
from
da388f9
to
ecb3210
Compare
| $to[] = $deceasedContactID . '::' . 'email@example.com'; | ||
| /* @var CRM_Contact_Form_Task_Email $form*/ | ||
| $form = $this->getFormObject('CRM_Contact_Form_Task_Email', [ | ||
| 'to' => implode(',', $to), |
There was a problem hiding this comment.
This is the key part of the change to this test - we are now passing 'to' as a submitted value rather than setting properties on the form (this is a good change)
|
Seems to run ok. I vaguely remember a previous attempt to remove toContact and it caused some problem, but maybe that was something else. |
|
@demeritcowboy yeah - I did try to do more on 'toContact' last time & hit issues - I think I've figured out the underlying problem now - ie because the static class was having to try to do stuff in preProcessit was insane.... A few more changes like this & it would start to be sane |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
[Ref] Extend email trait test, process more sanely
Builds on #21540 which is already a bit of a crazy battle!
Before
Weird process retrieves email addresses from the submitted 'to' values in the buildForm
After
Moved to the
postProcess- now testableTechnical Details
This is an artefact of the way the email tasks used to all pass
$formto a static function - it would up 'doing stuff where it could' inbuildFormnot in a sane place. This now usesgetSubmittedValues- the same could be extended to the other weird loading stuff later onComments