Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove handling for empty required field #21623

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

From is a required field - remove code to handle it being empty

Before

From is required - but the code still does a lot of work in case it's empty

image

After

poof

Technical Details

The function that the extra code was in was used from other places ... once upon a time but not now

Comments

@civibot
Copy link

civibot bot commented Sep 26, 2021

(Standard links)

@civibot civibot bot added the master label Sep 26, 2021
From is a required field - remove code to handle it being empty
@eileenmcnaughton
Copy link
Contributor Author

@demeritcowboy you might be able to confirm this?

@demeritcowboy
Copy link
Contributor

Sure will take a look.

@demeritcowboy demeritcowboy merged commit a7a2ae9 into civicrm:master Sep 27, 2021
@eileenmcnaughton
Copy link
Contributor Author

thanks @demeritcowboy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants