Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchKit - Sortable column fixes/improvements #21720

Merged
merged 1 commit into from
Oct 4, 2021

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Oct 4, 2021

Overview

Fix sortable column headers on SearchKit admin tables.
Make click-sortable column headers configurable.

Before

Sortable column headers broken on SearchKit admin screens.
Not configurable which headers were click-sortable when building a table display.

After

Fixed, configurable.

Fix sortable column headers on SearchKit admin tables
Make click-sortable column headers configurable
@civibot
Copy link

civibot bot commented Oct 4, 2021

(Standard links)

@civibot civibot bot added the master label Oct 4, 2021
@eileenmcnaughton
Copy link
Contributor

It seems to work & the optional click header works - I couldn't actually replicate the issue with it not working - but something like that was reported by a user

@eileenmcnaughton eileenmcnaughton merged commit 07d76bb into civicrm:master Oct 4, 2021
@eileenmcnaughton eileenmcnaughton deleted the fixSort branch October 4, 2021 22:49
@colemanw
Copy link
Member Author

colemanw commented Oct 5, 2021

I think it regressed in master, so you wouldn't have seen it in a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants