dev/core#398 FormBuilder: add 'Copy' button

[aydun]

Overview

Extend the FormBuilder 'repeat' functionality to add a button to create a new item with a copy of the previous item's values.
https://lab.civicrm.org/dev/core/-/issues/3986

The use case here is for creating a set of similar entities where most values are the same.

Before

Can 'Add' a new item

After

Can 'Add' a new item, and also 'Copy' to duplicate the previously entered values:

Click Copy

Then make changes to second entry etc

Technical Details

@colemanw Here's an attempt to produce a 'Copy' button, but it's fairly clueless copy/paste/hack!

This seems to work ok for a simple fieldset as in the screenshots. However, if you create a form for Contact and add the Email block, then the repeat type is 'join' and it fails with duplicates in the ngRepeat, which I think is because of cloneDeep Have you come across that before?

Also, the 'Copy' button appears whenever the 'Add' one does. Do you think it need separate configuration to allow form builders to specify whether 'Copy' is enabled?

Comments

Anything else you would like the reviewer to note

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

it fails with duplicates in the ngRepeat, which I think is because of cloneDeep Have you come across that before?

@aydun yes I have - the problem is that cloneDeep also clones Angular's secret $$id hash which is supposed to be unique. The solution is to use angular.copy() instead of loDash.cloneDeep().

[aydun]

it fails with duplicates in the ngRepeat, which I think is because of cloneDeep Have you come across that before?

@aydun yes I have - the problem is that cloneDeep also clones Angular's secret $$id hash which is supposed to be unique. The solution is to use angular.copy() instead of loDash.cloneDeep().

Thanks @colemanw ! That's fixed it.

One minor thing: the 'Add' and 'Copy' labels are editable, but do not allow spaces so you can configure 'AddEmail' but not 'Add Email'. Where is that restricted?

[colemanw]

One minor thing: the 'Add' and 'Copy' labels are editable, but do not allow spaces so you can configure 'AddEmail' but not 'Add Email'. Where is that restricted?

@aydun that's funny, I'm not seeing that problem on my end.

[aydun]

@aydun that's funny, I'm not seeing that problem on my end.

@colemanw I'm getting the problem on Firefox but not Chromium