mixin/scan-classes - Don't scan extension-tests automatically

[eileenmcnaughton]

Overview

Stop running class scanner in test directories

Before

When using the test frame work test directories were scanned for relevant classes

After

Test directories no longer scanned

Technical Details

The scanning was causing an edge case bug. If the scanner runs during bootstrap (ie because civicrm_initialize is called from the bootstrap file) then the classes are loaded at that point. Later when phpunit loads the test classes it does a scan and treates 'new_classes' as new test classes - but as these are already scanned they are not added to the list.

While rather edge this variant (tests silently not running) is worse than any variant of tests noisily failing.

Comments

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[totten]

I'd probably go for:

Suggested change

	* @mixinVersion 1.0.1
	* @mixinVersion 1.1.0

The change is in awkward spot. Formally, it's a BC-break (so it should be v2.0.0). But in practice, I don't think anyone actually has a live use for this edge-case (so v2.0.0 would be too heavy-handed). It's a little messed-up no matter what one does.

To my eye, 1.1.0 signals that there was a non-trivial change while also signaling that it's safe for 99% use-cases.

[eileenmcnaughton]

OK done - didn't spot that I could have just committed this so pushed in

[totten]

Aside: I think maybe that change wasn't actually pushed to Github? But it's small, so I pushed an equivalent update.

[totten]

Since this file has both implicit test-coverage (via search_kit, authx, et al) as well as explicit test-coverage (via mixin/scan-classes\@1/example/), I think tests results will be meaningful. Merge on pass.