Drupal 7, refuse the possibility to execute the REST API with blocked users #26185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This block the possibility to execute the rest API with blocked drupal users
|
(Standard links)
|
|
I can't remember if authx indirectly calls this but note that the default policy for some authx scenarios is "optional", meaning that the user doesn't have to be a valid user. So we should test if this prevents authx from working in those scenarios - see https://docs.civicrm.org/dev/en/latest/framework/authx/#settings |
rubofvil
changed the title
rubofvil
changed the title
|
I think this is ok. I don't believe the authx setting of optional is meant as an "override" of cms settings, and it doesn't seem to be a problem. Have put merge-ready. |
demeritcowboy
added
the
merge ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refuse the possibility to execute the REST API with blocked users in drupal 7.
Overview
Security issue using the REST API.
User blocked can acces to the API by REST.
Before
A user blocked in drupal 7 accessing by API REST (.../modules/contrib/civicrm/extern/rest.php?entity=Contact&action=get&json={"s..."}&api_key=FIXME_USER_KEY&key=FIXME_SITE_KEY')
can access to info
After
The user is blocked to use the API REST