[REF] Move repeated code for Price Field labels into separate function

[larssandergreen]

Overview

This is a first step towards some other improvements, but all this PR does is make this code more maintainable by moving a lot of repeated copy-pasted text into a separate function.

The code was not entirely identical in some places (for instance, before the pre and post help for selects had no spans around them, now they do, sold out markings missing on select options, now present), but I think these were oversights that were changed in one place and not in others. There is no significant functional change.

Comments

Lines 294-297 are now redundant for all cases except text fields. They'll be removed in the following PR but need to stay for now so that text fields keep working.

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

Not a blocker but it would be really cool if you got rid of the deprecated CRM_Utils_Array::value calls while you're in here. That function is always a bit ambiguous but I'm guessing this is what it's trying to do:

Suggested change

	$count = CRM_Utils_Array::value('count', $opt, '');
	$max_value = CRM_Utils_Array::value('max_value', $opt, '');
	$count = $opt['count'] ?? '';
	$max_value = $opt['max_value' ?? '';

[larssandergreen]

For sure! (I did this one before I learned about getting rid of those).

[eileenmcnaughton]

Oh wow - good detective work - I had never spotted those parts of the case-from-hell were copy & paste

[colemanw]

Code looks good to me. Anyone able to r-run?

[eileenmcnaughton]

I can't see any difference...so I think this is a mergeable improvement.

The only thing I would (& might) change is to make the function protected and / or comment it to make it clear it is not supported for use outside of core. That is implicit anyway but making it explicit is better

[larssandergreen]

Thanks @eileenmcnaughton and @colemanw. Here's the next refactor step for this.

[mlutfy]

Found a regression with Select fields: https://lab.civicrm.org/dev/core/-/issues/4439