CRM-19472 - Export headers for relationships are in machine name format #9187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
---------------------------------------- * CRM-19472: Export headers for relationships are in "machine name" format https://issues.civicrm.org/jira/browse/CRM-19472
|
Can one of the admins verify this patch? |
|
test this please |
| @@ -2118,6 +2117,8 @@ public static function setHeaderRows($field, $headerRows, $sqlColumns, $query, $ | |||
| $headerRows[] = $field; | |||
| } | |||
|
|
|||
| self::manipulateHeaderRows($headerRows, $contactRelationshipTypes); | |||
There was a problem hiding this comment.
QA'd the PR, works fine and corrects the header for relationships. Just thinking if we could avoid calling of this method for every field and instead move this call to a little upward immediately after $headerRows of contact relationships are evaluated ?
|
@sqweets could you please make the recommended change and we'll get this merged, thanks. |
---------------------------------------- * CRM-19472: Export headers for relationships are in "machine name" format https://issues.civicrm.org/jira/browse/CRM-19472
|
The recommended change has been made. That is a better spot, thanks. |
|
@civicrm-builder add to whitelist |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.civicrm.org/jira/browse/CRM-19472