Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRM-19649 - Multiple wysiwyg config presets #9419

Merged
merged 3 commits into from
Nov 21, 2016
Merged

CRM-19649 - Multiple wysiwyg config presets #9419

merged 3 commits into from
Nov 21, 2016

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Nov 21, 2016 •
edited by civicrm-builder
Loading

@colemanw
Copy link
Member Author

colemanw commented Nov 21, 2016 •
edited
Loading

@lcdservices this is ready for testing. This feature allows you to set different CKEditor configurations based on context (I've added a couple presets for now, we can add more later - see tabs in the screenshot).

@JKingsnorth note that we are reverting the fullPage setting from #7993 because it broke existing functionality where the html <head> and <body> tags were in the message header/footer. So instead of hard-coding the fullPage option for CiviMail, you can configure whatever settings you want for that preset via the UI.

ckeditor config

@colemanw colemanw merged commit ff61eaa into civicrm:master Nov 21, 2016
@colemanw colemanw deleted the CRM-19649 branch November 21, 2016 17:04
@JKingsnorth
Copy link
Contributor

Thanks for the heads up on this. Seems to work well =]

@mfb
Copy link
Contributor

mfb commented Apr 10, 2019 •
edited
Loading

Message templates are confusing, because in some parts of the Civi UI, they can be sent on their own, without any separate header/footer, while in other parts of the UI, they can be wrapped with a header and footer.

That seems confusing / complicated (to me :)

It seems like we want some way to indicate whether a message template already has its header and footer, or is designed to be wrapped in a header and footer. If the former, then fullPage should be set to true. If the latter, then fullPage should be set to false.

@mfb
Copy link
Contributor

mfb commented Apr 11, 2019

I opened https://lab.civicrm.org/dev/mail/issues/42 as a proposal for more work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@colemanw @JKingsnorth @mfb @civicrm-builder